[#29430] - Check if the versions object has the property
- Fixed in Code Base
- 7 Jun 2020
- Medium
- Build: staging
- # 29430
- Diff
- Digital-Peak:j3/versions
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Staging pull request for issue #27214, basically a backport of #27493.
Summary of Changes
When comparing two versions of an article a warning is thrown:
Deprecated: array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead
This pr fixes it.
Testing Instructions
- Ensure versions is enabled in the articles options in the editing layout tab
- Create an article
- Edit the title and save the article again
- Edit the title again and save it
- Click on the versions button
- Select the two versions
- Click on compare
Expected result
No warning is thrown.
Actual result
A warning is thrown.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29430.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29430.
Thanks!
I saw your second commit changing isset to property_exists since it's a backport it's not applicable so only a notice for others. Using isset is faster because it's a language construct and not a function call beside that it wouldn't throw a notice if $object->data is not defined.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-07 08:30:11 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thankyou <3 !!
I have tested this item✅ successfully on 8b4f0b5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29430.