NPM Resource Changed ? ? ? Pending
Pull Request for # 29300

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
1 Jun 2020

Fixes #29300.

Summary of Changes

Fixes two factor authentication forms not being shown in frontend.
Fixes selected TFA method form not shown in backend (probably).
Removes duplicate JS.

Testing Instructions

Enable some two factor authentication plugins.
Edit profile in frontend.
Select TFA method in the dropdown.

Expected result

TFA setup form shown.

Actual result

TFA setup form not shown.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 1 Jun 2020
avatar SharkyKZ SharkyKZ - change - 1 Jun 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2020
Category Administration com_users JavaScript Repository NPM Change Front End
avatar SharkyKZ SharkyKZ - change - 1 Jun 2020
Rel_Number 29300
Relation Type Pull Request for
Labels Added: ? NPM Resource Changed
avatar SharkyKZ SharkyKZ - change - 1 Jun 2020
Labels
avatar richard67
richard67 - comment - 1 Jun 2020

Added release blocker label as inherited from the issue.

avatar richard67 richard67 - test_item - 2 Jun 2020 - Tested successfully
avatar richard67
richard67 - comment - 2 Jun 2020

I have tested this item successfully on 5446723


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29365.

avatar bonzani bonzani - test_item - 2 Jun 2020 - Tested successfully
avatar bonzani
bonzani - comment - 2 Jun 2020

I have tested this item successfully on 5446723


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29365.

avatar richard67 richard67 - change - 2 Jun 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jun 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29365.

avatar wilsonge wilsonge - change - 5 Jun 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-06-05 10:50:22
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 5 Jun 2020

Thanks!

Add a Comment

Login with GitHub to post a comment