NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
31 May 2020

Pull Request for Issue # 0469adb .

Summary of Changes

Restores the Joomla namespace for couple variables

As a remark here the XTD button Media:

  • should have it's own script
  • shouldn't use hardcoded onclick

As is in a form that doesn't have a media field the editor image button is broken.

Testing Instructions

Check that you can insert an image in tinyMCE

Expected result

Working

Actual result

Broken

Documentation Changes Required

No, this was my bad

@wilsonge sorry mate I totally forgot that this code was also used in the xtd button.

avatar dgrammatiko dgrammatiko - open - 31 May 2020
avatar dgrammatiko dgrammatiko - change - 31 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2020
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 31 May 2020
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - change - 31 May 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-31 20:33:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 May 2020
avatar wilsonge wilsonge - merge - 31 May 2020
avatar wilsonge
wilsonge - comment - 31 May 2020

Oops :) I should have tested harder too - thankyou!

Add a Comment

Login with GitHub to post a comment