? Pending

User tests: Successful: Unsuccessful:

avatar particthistle
particthistle
23 May 2020

Change the type for header_class to textarea to resolve #29183

Pull Request for Issue #29183.

Summary of Changes

Change the type for header_class to textarea

Testing Instructions

  • Edit a module
  • Go to the Advanced settings tab for the module
  • Header Class will now be a textarea instead of a text field.

Expected result

image

Actual result

Documentation Changes Required

avatar particthistle particthistle - open - 23 May 2020
avatar particthistle particthistle - change - 23 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2020
Category Administration com_modules
avatar chmst chmst - test_item - 23 May 2020 - Tested successfully
avatar chmst
chmst - comment - 23 May 2020

I have tested this item successfully on 658763c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29201.

avatar rinka88
rinka88 - comment - 23 May 2020

It’s better to do rows = "1" rather than rows = "3" so that all cells / fields are the same size

avatar Quy
Quy - comment - 23 May 2020

@rinka88 It is to be consistent with Module Class.

avatar adj9 adj9 - test_item - 24 May 2020 - Tested successfully
avatar adj9
adj9 - comment - 24 May 2020

I have tested this item successfully on 658763c

I confirm the change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29201.

avatar zero-24 zero-24 - change - 24 May 2020
Labels Added: ?
avatar zero-24
zero-24 - comment - 24 May 2020

Merging thanks ?

avatar zero-24 zero-24 - close - 24 May 2020
avatar zero-24 zero-24 - merge - 24 May 2020
avatar zero-24 zero-24 - change - 24 May 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-24 09:17:50
Closed_By zero-24

Add a Comment

Login with GitHub to post a comment