? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
23 May 2020

Summary of Changes

On smaller screens the tilte + alias is ugly broken on articles and categories overview. This PR adds a line break before Alias

Testing Instructions

Compare list views of artiles / featured articles / categories before and after patch

newline-alias

Documentation Changes Required

screen

avatar chmst chmst - open - 23 May 2020
avatar chmst chmst - change - 23 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2020
Category Administration com_categories com_content
avatar chmst chmst - change - 23 May 2020
Easy No Yes
avatar brianteeman
brianteeman - comment - 23 May 2020

Do we really need the alias on this view. To me it is unnecessary clutter

avatar chmst
chmst - comment - 23 May 2020

This is another question ;) I don't need the alias and it is a point for a "backend light". But maybe SEO lovers have sophisticated aliases

avatar chmst
chmst - comment - 23 May 2020

The more Ithink about, the more Ilike the Idea of removing the alias, but really don't know when it is used. Maybe a condition: show the alias only if it is != default?

avatar richard67
richard67 - comment - 23 May 2020

Yes, another use case for configurable list views. Personally for me the alias is important so I like to see it here.

avatar richard67
richard67 - comment - 23 May 2020

@chmst Aliases are used for SEO friendly URLs, routing.

avatar particthistle
particthistle - comment - 23 May 2020

Alias on this view I think is essential.

  • The ability to find if an alias is clean and matching a problematic URL is a key troubleshooting measure if there's been a copied article for example and that process has been missed.
  • Identifying it as Alias I think is helpful for users.
avatar infograf768
infograf768 - comment - 23 May 2020

Agree with new line, BUT the main problem is:

Same window size
3.x

Screen Shot 2020-05-23 at 11 25 11

4.x menu untoggled

Screen Shot 2020-05-23 at 11 25 39

4.x menu toggled

Screen Shot 2020-05-23 at 11 25 52

in 4.x we have to reduce to ~80% to have a full reading.

avatar carcam carcam - test_item - 23 May 2020 - Tested successfully
avatar carcam
carcam - comment - 23 May 2020

I have tested this item successfully on dbc2aaa

With menu toggled it looks fine. In any case, we might hide the "alias" text?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29200.

avatar brianteeman
brianteeman - comment - 23 May 2020

In any case, we might hide the "alias" text?

I wrote the code for that but the code was not "clever" enough for some people to be accepted so I closed the Pr

avatar adj9 adj9 - test_item - 23 May 2020 - Tested successfully
avatar adj9
adj9 - comment - 23 May 2020

I have tested this item successfully on dbc2aaa

by reducing Chrome, I have the result
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29200.
avatar ReLater
ReLater - comment - 23 May 2020

Just because you talk about removing (the new culture) further informations. Why don't we give all these SPANs and DIVs individual CSS classes. Then you need 5, 6 lines of CSS to hide/show them and users can use a custom.css to override your decision; instead of PHP overrides, JS or whatever.

23-05-_2020_12-53-44

.

avatar ReLater
ReLater - comment - 23 May 2020

And we wouldn't need a ugly <br> for a new line but could use a display:block; or similiar whereever wanted.

avatar chmst
chmst - comment - 23 May 2020

@ReLater the div is a good idea, thank you for that, I will commit again.

Additionally - Joomla allows overrides, in backend as in frontend. So everyone can remove or add elements.

avatar brianteeman
brianteeman - comment - 23 May 2020

Additionally - Joomla allows overrides, in backend as in frontend. So everyone can remove or add elements.

Thats uglier that my suggestion ;)

avatar chmst
chmst - comment - 23 May 2020

@adj9 @carcam it woud be great if you could repeat the test. On the screen nothing has changed.

avatar chmst
chmst - comment - 23 May 2020

@ReLater @infograf768 @brianteeman in this PR I just wanted to improve the view. The other issues are real but out of scope here.

avatar rinka88
rinka88 - comment - 23 May 2020

Isn't it better to remove the word in the Status section, leaving only the icon?
Or even like joomla 3, impoverish the Status and Featured section.

avatar carcam
carcam - comment - 23 May 2020

@chmst

it woud be great if you could repeat the test. On the screen nothing has changed.

the div is a good idea, thank you for that, I will commit again.

Should we retest or close this per and wait for the new one with the div? Latest seem better to me ;)

avatar richard67
richard67 - comment - 23 May 2020

@carcam The change to div has been included into this PR here with the latest commit.

avatar carcam
carcam - comment - 23 May 2020

Great!! Will retest!! Thank you!!

avatar toivo toivo - test_item - 24 May 2020 - Tested successfully
avatar toivo
toivo - comment - 24 May 2020

I have tested this item successfully on a045a43

Tested successfully in Nightly Build of 24 May.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29200.

avatar carcam carcam - test_item - 24 May 2020 - Tested successfully
avatar carcam
carcam - comment - 24 May 2020

I have tested this item successfully on a045a43

I have retested and this PR address correctly the problem it tries to solve. It might be worthed to note that this issue is better experienced in big screens and solution works better for them.

In smaller screens the Title column is too narrow and it doesn't look that nice.

Before the patch
Captura de pantalla 2020-05-24 a las 16 21 44

After the patch:
Captura de pantalla 2020-05-24 a las 16 23 14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29200.
avatar richard67 richard67 - change - 24 May 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29200.

avatar richard67 richard67 - change - 24 May 2020
Labels Added: ? ?
avatar wilsonge wilsonge - change - 24 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-24 15:39:13
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 24 May 2020
avatar wilsonge wilsonge - merge - 24 May 2020
avatar wilsonge
wilsonge - comment - 24 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment