NPM Resource Changed ? ? Pending
Pull Request for # 29140

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
19 May 2020

Pull Request for Issue #29140.

Summary of Changes

Fixes module form buttons in frontend.

Testing Instructions

Run node build.js --compile-js.

Edit a module in frontend.
Click on the icon within one of the form buttons.

Expected result

Form submitted.

Actual result

JS error:

TypeError: form is undefined validate.js:265:22

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 19 May 2020
avatar SharkyKZ SharkyKZ - change - 19 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2020
Category JavaScript Repository NPM Change
avatar SharkyKZ SharkyKZ - change - 19 May 2020
Rel_Number 29140
Relation Type Pull Request for
Labels Added: ? NPM Resource Changed
avatar C-Lodder
C-Lodder - comment - 19 May 2020

Still not working.
If you click on the "x" icon within the Cancel button, the error still appears

avatar SharkyKZ
SharkyKZ - comment - 19 May 2020

@C-Lodder did you run node build.js --compile-js?

avatar SharkyKZ SharkyKZ - change - 19 May 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 19 May 2020
avatar C-Lodder
C-Lodder - comment - 19 May 2020

I just made the change directly in the compiled file

avatar SharkyKZ SharkyKZ - change - 20 May 2020
Labels
avatar Quy Quy - test_item - 20 May 2020 - Tested successfully
avatar Quy
Quy - comment - 20 May 2020

I have tested this item successfully on 362179f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29141.

avatar SharkyKZ
SharkyKZ - comment - 20 May 2020

@C-Lodder are you sure you edited the correct file?

avatar chmst chmst - test_item - 23 May 2020 - Tested successfully
avatar chmst
chmst - comment - 23 May 2020

I have tested this item successfully on 362179f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29141.

avatar Quy Quy - change - 23 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29141.

avatar zero-24
zero-24 - comment - 23 May 2020

@C-Lodder could you made this work? Or do you still see an issue here?

avatar C-Lodder
C-Lodder - comment - 24 May 2020

It's working

avatar zero-24
zero-24 - comment - 24 May 2020

Thanks for confiming. Merging now.

avatar zero-24 zero-24 - change - 24 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-24 08:59:09
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 24 May 2020
avatar zero-24 zero-24 - merge - 24 May 2020

Add a Comment

Login with GitHub to post a comment