Feeling Lucky
?
[#29051] - Fix TagsHelper::createTagsFromField() method to set parent_id for newTags. Add Rebuild Button to tags manager
- Closed
- 14 May 2020
- Medium
- Build: staging
- # 29051
- Diff
- ggppdk:fix_createTagsFromField_parent_id
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #29015 , #29033 ?? (i have not tested) (i have only tested by own extension)
Summary of Changes
TagsHelper::createTagsFromField() is not setting
parent_id
But when not setting parent_id,
- the DB 's default for the column parent_id is used, which is '0'
thus the tag is created with parent_id is 0 instead of the expected parent_id which is 1 (the id of the root record)
As said above in my case the tags were created with parent_id zero
NOTE: This PR does not fix the any tags already created with parent_id 0
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration Libraries |
| Labels |
Added:
?
|
||
| Category | com_tags Administration Libraries | ⇒ | Administration com_postinstall com_tags Front End com_users Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-14 18:28:04 |
| Closed_By | ⇒ | ggppdk |
I can't reproduce the issue with core components. Any idea why this would be needed? Shouldn't setting location as parent's child handle this anyways?