Only Problem I have here, is that we use the same Icon for "default" as for "featured" items. IMO that are two completely different functions.

I would not worry about that. The star is a only a way to differentiate in these cases the ON/OFF status. We are used to it.

Only Problem I have here, is that we use the same Icon for "default" as for "featured" items. IMO that are two completely different functions.

I would not worry about that. The star is a only a way to differentiate in these cases the ON/OFF status. We are used to it.

We are used to it but new users might find it not logical. That's the issue. Star is to make something default OR featured. In my opinion one icon/sign should do only one thing.

I have tested this item ✅ successfully on 0e1fb62

rtc
I suggest the discussion about the icon used to be separated.

I have tested this item ✅ successfully on 0e1fb62

Hmm
@coolcat-creations
When admin style is set to use Monochrome, it is very hard to differentiate between Default and not default. Example: Here Atum-Default (2) is default and set to monochrome

Maybe I do a second PR with all about used colors in the backend in all areas? @infograf768

This is exactly why colour alone should never be used as an indicator

This is exactly why colour alone should never be used as an indicator

I think I solved this for the home item - and with the home item PR I can add now different classes for the items depending on the state. I add the change here, ok?

The colour

color: var(--warning);
border-color: var(--warning);

We can modify the variable when monochrome is on and add classes in index.php
In this case, I guess it should be var(--black) and .monochrome

No idea if this should be done for all colours in a specific PR or here.

Again - just using colour to indicate anything is an accessibility failure and should not be done.

Updated title and description of the PR and changed icon appereance

thanks @coolcat-creations

Please correct cs

 FILE: /********/src/libraries/src/Button/FeaturedButton.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 32 | WARNING | Line exceeds 150 characters; contains 168
    |         | characters (Generic.Files.LineLength.TooLong)
 33 | WARNING | Line exceeds 150 characters; contains 166
    |         | characters (Generic.Files.LineLength.TooLong)

I have tested this item ✅ successfully on 5b91907

Please correct cs

 FILE: /********/src/libraries/src/Button/FeaturedButton.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 32 | WARNING | Line exceeds 150 characters; contains 168
    |         | characters (Generic.Files.LineLength.TooLong)
 33 | WARNING | Line exceeds 150 characters; contains 166
    |         | characters (Generic.Files.LineLength.TooLong)

Was the line break ok?

I'm afraid it is still not right

 FILE: /********/src/libraries/src/Button/FeaturedButton.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 32 | ERROR | [x] Whitespace found at end of line
    |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 33 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 8 spaces but found 16. Note: the autofixer
    |       |     will convert spaces to tabs
    |       |     (PEAR.Functions.FunctionCallSignature.Indent)
 33 | ERROR | [x] Closing parenthesis of a multi-line function call
    |       |     must be on a line by itself
    |       |     (PEAR.Functions.FunctionCallSignature.CloseBracketLine)
 34 | ERROR | [x] Whitespace found at end of line
    |       |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 35 | ERROR | [x] Multi-line function call not indented correctly;
    |       |     expected 8 spaces but found 16. Note: the autofixer
    |       |     will convert spaces to tabs
    |       |     (PEAR.Functions.FunctionCallSignature.Indent)
 35 | ERROR | [x] Closing parenthesis of a multi-line function call
    |       |     must be on a line by itself

Sorry, how can I fix that?

I think something like this: take off one tab, useless space, move parenthesis on 3rd line.

I think something like this: take off one tab, useless space, move parenthesis on 3rd line.

Thank you! Does it work now?

No, you have not done what I suggested.

Will try to modify your branch

OK now

Thank you for your help!

Drone still broken but not due to the PR.

Would be also good to know if I was allowed to change the icomoon file...

Needs one more tester here.

I have tested this item ✅ successfully on 127c466

RTC

Tks