Feeling Lucky
?
?
[#28996] - Fix form validation when using patterns
- Fixed in Code Base
- 26 May 2020
- Medium
- Build: staging
- # 28996
- Diff
- SharkyKZ:patch-3
- Pending Hound Hound is busy sniffing around... Details
Pull Request for
# 20789
User tests: Successful: Unsuccessful:
Pull Request for Issue #20789.
Summary of Changes
Declares variable using var to limit its scope and prevent overwriting function.
Testing Instructions
Add pattern attribute to some form field.
E.g. pattern="[A-Za-z\s0-9]+" to name field in components\com_users\models\forms\registration.xml,
Try to register with name containing invalid characters.
Expected result
Form not submitted with error:
Invalid field: Name
Actual result
Browser's validation tooltip is shown and we get JS error:
TypeError: isValid is not a function
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Rel_Number | ⇒ | 20789 | |
| Relation Type | ⇒ | Pull Request for | |
| Labels |
Added:
?
|
||
bonzani
- comment
- 24 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28996.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 24 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28996.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-26 12:37:21 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 26 May 2020
Thanks
I have tested this item✅ successfully on 7eca2d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28996.