[#28972] - [4.0] Template Atum - Remove static text
- Fixed in Code Base
- 8 May 2020
- Medium
- Build: 4.0-dev
- # 28972
- Diff
- coolcat-creations:patch-6
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Change for issue #28970
Summary of Changes
Add JText instead of static text
Testing Instructions
Apply the patch
Check if the Aria Label of Navbar Toggler is still correct
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I took the same Jtext as the label of the “menu item” I think that should be good so far. Do you have any concerns about the naming?
I don’t have concerns. I only asked because neither the description nor the testing instructions mentioned the change. Instructions only say to check if the text is still the right one. So the change formally would mean a bad test due to wrong instructions
But I’d like to know @brianteeman ‘s opinion on the change of the aria label, what is better, toggle menu or toggle navigation, or if both is same ok.
Good spot @richard67 and thanks for raising it. In this case the change is correct as it ensures that they are both the same which they should have been
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28972.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28972.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28972.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-08 07:20:21 |
| Closed_By | ⇒ | infograf768 | |
| Labels | |||
Tks
The aria label has changed. Without the PR it's "Toggle navigation", with the PR it's "Toggle Menu" (JTOGGLE_SIDEBAR_MENU). There is a language sting for "Toggle Navigation", but only for Cassiopeia (TPL_CASSIOPEIA_TOGGLE).
Is that intended?