[#28971] - [4.0] Template Atum - Change Main Color Names and Variables
- Closed
- 29 May 2022
- Medium
- Build: 4.0-dev
- # 28971
- Diff
- coolcat-creations:rename-colors
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Renamed everything what has in common with the bg-dark color to Primary colour and the special color to secondary color. Moved the secondary color into the first column ob the backend settings.
Testing Instructions
Apply the patch
npm run build:css
The color names in the setting should be now primary and secondary color and everything should work just like before the patch.
Reason of the change
Every modern framework uses the terms Primary Color and Secondary color and for increased usability I suggest to change the naming in Joomla.
Also it does not fix a color to have a specific brightness. Since the dark sidebar is gone and we don't need anymore to calculate all the shades of the sidebar for a11y another step would be also to remove the hue slider and replace it by a colorfield where the user is free to chose the color.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Templates (admin) |
Why not use TPL_ATUM_COLORS_SETTINGS_PRIMARY_COLOUR_LABEL instead of the long sentence for a label?
| Labels |
Added:
?
?
|
||
Why not use
TPL_ATUM_COLORS_SETTINGS_PRIMARY_COLOUR_LABELinstead of the long sentence for a label?
Actually as said above I would rather replace the hue field by really a primary colour field so this would be solved with another PR. The hue made sense when we calculated colors for the sidebar - now quite not anymore I think.
| Labels |
Added:
Conflicting Files
|
||
| Category | Administration Language & Strings Templates (admin) | ⇒ | Administration Language & Strings Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
@coolcat-creations please can you fix the conflicts
@coolcat-creations we need conflicts fixed so we can test this. Thanks Hurricane :)
@coolcat-creations as we have BS Version 5 - is this still valid? If yes: could you please resolve the conflicts?
@coolcat-creations can you please solve the conflicts, so that we can test this pr. Thanks
Hey, can anyone direct me to how to resolve conflicts? The button is disabled.
This may be considered an improvement and not a bug. It would be easier to close the PR and do it for the 4.2 branch.
It's on my plan to redo this PR next week. I tried to merge 4.1 into this but it really seems too complicated...
Closing. To redo in v4.2.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-29 16:44:59 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Language Change
?
?
Removed: ? ? |
||