Language Change PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
6 May 2020

Summary of Changes

Renamed everything what has in common with the bg-dark color to Primary colour and the special color to secondary color. Moved the secondary color into the first column ob the backend settings.

Testing Instructions

Apply the patch
npm run build:css
The color names in the setting should be now primary and secondary color and everything should work just like before the patch.

grafik

Reason of the change

Every modern framework uses the terms Primary Color and Secondary color and for increased usability I suggest to change the naming in Joomla.

Also it does not fix a color to have a specific brightness. Since the dark sidebar is gone and we don't need anymore to calculate all the shades of the sidebar for a11y another step would be also to remove the hue slider and replace it by a colorfield where the user is free to chose the color.

avatar coolcat-creations coolcat-creations - open - 6 May 2020
avatar coolcat-creations coolcat-creations - change - 6 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2020
Category Administration Language & Strings Templates (admin)
avatar brianteeman
brianteeman - comment - 6 May 2020

The color names in the setting should be now primary and secondary color
Sensible change - thanks

avatar Quy
Quy - comment - 6 May 2020

Why not use TPL_ATUM_COLORS_SETTINGS_PRIMARY_COLOUR_LABEL instead of the long sentence for a label?

avatar coolcat-creations coolcat-creations - change - 6 May 2020
Labels Added: Language Change PR-4.0-dev
avatar coolcat-creations
coolcat-creations - comment - 6 May 2020

Why not use TPL_ATUM_COLORS_SETTINGS_PRIMARY_COLOUR_LABEL instead of the long sentence for a label?

Actually as said above I would rather replace the hue field by really a primary colour field so this would be solved with another PR. The hue made sense when we calculated colors for the sidebar - now quite not anymore I think.

Add a Comment

Login with GitHub to post a comment