? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
6 May 2020

Pull Request for Issue # .

Summary of Changes

The drag and drop plugin has a hardcoded path. This PR is forcing it to use the CMS' own override policy by utilising HTMLHelper. Plain English: you can override it by placing an override file in your template's js folder (following the established convention)

Testing Instructions

Apply the patch and creat/edit an article. Drag and drop an image to verify that the functionality is still there

Expected result

Allow to override the plugin using the CMS' established convention

Actual result

Plugin cannot be overridden

Documentation Changes Required

This is not a new feature, we just properly call the plugin.

avatar dgrammatiko dgrammatiko - open - 6 May 2020
avatar dgrammatiko dgrammatiko - change - 6 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2020
Category Front End Plugins
6176ac1 6 May 2020 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 6 May 2020
Labels Added: ?
fe55fe9 6 May 2020 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 6 May 2020
Title
Allow tinyMCE's dnd plugin to use be overridden
Allow tinyMCE's dnd plugin to be overridden
avatar dgrammatiko dgrammatiko - edited - 6 May 2020
avatar SharkyKZ
SharkyKZ - comment - 6 May 2020
avatar dgrammatiko
dgrammatiko - comment - 6 May 2020

@SharkyKZ should be fine now

avatar viocassel viocassel - test_item - 6 May 2020 - Tested successfully
avatar viocassel
viocassel - comment - 6 May 2020

I have tested this item successfully on d174ad4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28961.

avatar adj9 adj9 - test_item - 6 May 2020 - Tested successfully
avatar adj9
adj9 - comment - 6 May 2020

I have tested this item successfully on d174ad4

load img and see in article with drag and drop in TinyMCE


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28961.

avatar Quy Quy - change - 6 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28961.

avatar dgrammatiko
dgrammatiko - comment - 8 May 2020

@HLeithner can I have a verdict on this one? Thanks

avatar HLeithner HLeithner - change - 8 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-08 08:58:12
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 8 May 2020
avatar HLeithner HLeithner - merge - 8 May 2020
avatar HLeithner
HLeithner - comment - 8 May 2020

Thanks

avatar dgrammatiko
dgrammatiko - comment - 8 May 2020

Thank you 👍

Add a Comment

Login with GitHub to post a comment