Feeling Lucky
?
[#28960] - [4.0] Add extension name/id to uninstall message if extension is locked, redo of PR 28916
- Fixed in Code Base
- 6 May 2020
- Medium
- Build: 4.0-dev
- # 28960
- Diff
- richard67:4.0-dev-redo-pr-28916
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a redo of PR #28916 . Thanks @ReLater for the implementation.
- Change lang string COM_INSTALLER_UNINSTALL_ERROR_LOCKED_EXTENSION.
- Use sprintf to display extension name and id.
Testing Instructions
- 4.0 nightly build of today (Wednesday, 06 May 2020) or later.
- Go to extensions manager (
administrator/index.php?option=com_installer&view=manage). - Select many locked extensions.
- Click
Uninstalland check the messages at the top. - CLI: Use
php cli/joomla.php extension:remove xxx, withxxxbeing an extension ID for a locked core extension, e.g.Action Log - Joomla.
Actual result
In backend in extensions manage:
CLI:
Expected result after applying PR
In backend in extensions manage:
CLI:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Language & Strings Libraries |
richard67
- comment
- 6 May 2020
@ChristineWk Please test.
ChristineWk
- comment
- 6 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 6 May 2020
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-06 09:18:55 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 6 May 2020
Tks to both
I have tested this item✅ successfully on 580ff13
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28960.