NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 May 2020

Summary of Changes

Fixes JS validation for required checkboxes.

Testing Instructions

Create a form containing required checkbox.

E.g. add required="true" to both field in administrator/components/com_languages/forms/override.xml:

<field
	name="both"
	type="checkbox"
	label="COM_LANGUAGES_OVERRIDE_FIELD_BOTH_LABEL"
	value="true"
	filter="boolean"
	required="true"
/>

Go to Language Override form. Check the checkbox and click somewhere on the page.

Expected result

No validation warning shown.

Actual result

Warning shown:

One of the options must be selected

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 5 May 2020
avatar SharkyKZ SharkyKZ - change - 5 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2020
Category JavaScript Repository NPM Change
avatar Quy Quy - test_item - 5 May 2020 - Tested successfully
avatar Quy
Quy - comment - 5 May 2020

I have tested this item successfully on b7d1382


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28942.

avatar chmst
chmst - comment - 16 May 2020

The test of js is successfull but the result is not correct.
If a checkbox is required, but the user did not check, the messag is "One of the options must be selected".
While there are not several options.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28942.

avatar SharkyKZ
SharkyKZ - comment - 16 May 2020

@chmst That's out of scope of this PR.

avatar chmst chmst - test_item - 16 May 2020 - Tested successfully
avatar chmst
chmst - comment - 16 May 2020

I have tested this item successfully on b7d1382


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28942.

avatar richard67 richard67 - change - 16 May 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 16 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28942.

avatar richard67 richard67 - change - 16 May 2020
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - change - 18 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-18 22:09:45
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 18 May 2020
avatar wilsonge wilsonge - merge - 18 May 2020
avatar wilsonge
wilsonge - comment - 18 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment