? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 May 2020

Fixes #28935.

Summary of Changes

Fixes menu field validation and simplify related code in other modal fields.

Testing Instructions

  • Create a new menu item (back-end)

  • Select "Menu Item Type": "Menu Item Alias"

  • DO NOT select a "Menu Item"!!

  • Save.

Expected result

  • It should not be possible to save the menu item

Actual result

  • One can save the menu item.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - change - 5 May 2020
Status New Pending
avatar SharkyKZ SharkyKZ - open - 5 May 2020
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2020
Category Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds Layout
avatar ceford ceford - test_item - 5 May 2020 - Tested successfully
avatar ceford
ceford - comment - 5 May 2020

I have tested this item successfully on 5fb747c

I have just set up for testing and this is my first test - it was at the top of the list.

Tested with en, fr and de installed. Menu Title and Menu Item both show red when not filled out. Save works correctly when fields are correctly filled out.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28937.

avatar jwaisner jwaisner - test_item - 5 May 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 May 2020

I have tested this item successfully on 5fb747c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28937.

avatar jwaisner jwaisner - change - 5 May 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 5 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28937.

avatar richard67 richard67 - close - 6 May 2020
avatar richard67 richard67 - merge - 6 May 2020
avatar richard67 richard67 - change - 6 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-06 11:52:50
Closed_By richard67
Labels Added: ?
avatar richard67
richard67 - comment - 6 May 2020

Thanks all.

Add a Comment

Login with GitHub to post a comment