[#28936] - [4.0] Implementing administrator template preview
- Fixed in Code Base
- 7 May 2020
- Medium
- Build: 4.0-dev
- # 28936
- Diff
- infograf768:4.0_admintemplate_preview
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28932
Summary of Changes
As title says.
Testing Instructions
Enable Preview in Template Options
In each template manager filter by Administrator client
After patch
Templates Manager will show Preview button for Atum
Templates styles Manager will also get a Preview button
Clicking Preview button
We now get
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
On it.
| Labels |
Added:
?
?
|
||
I have tested this item
It does what the screenshots show. It seems testing helps learning - I did not know there was template positions preview!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28936.
I have tested this item
Works as expected. Even duplicated and confirmed that other functions within the administrator templates and styles works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28936.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28936.
| Labels |
Added:
?
|
||
Was only cs. Can stay rtc
Template preview doesn't show on PDO. $item->client_id needs to be cast to integer. But it was same before this patch, so can be fixed in separate PR.
Please fix conflicts.
Should be OK now.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-07 09:48:22 |
| Closed_By | ⇒ | rdeutz |
Can you remove the duplicated code? There is no need for client check anymore except when building the preview link.