[#28934] - [3.9] Incorrect message when saving profile in control panel
- Closed
- 5 May 2020
- Medium
- Build: staging
- # 28934
Steps to reproduce the issue
Log in the control panel and press Edit Account, then click Save. You can see the message about saving to the profile in an unusual way :).
Among other things, the file with the original constant is loaded, and then en-GB.com_messages.ini.
JLIB_APPLICATION_SAVE_SUCCESS="Item saved."
JLIB_APPLICATION_SAVE_SUCCESS="Message sent."
Language Files Loaded
**Loaded** : JROOT\administrator\language\en-GB\en-GB.lib_joomla.ini
...
**Loaded** : JROOT\administrator\language\en-GB\en-GB.com_messages.ini
Need your own constant for "message sent" in the private message component.
System information (as much as possible)
Joomla 3.9.18
PHP 7.3.2
| Labels |
Added:
?
|
||
We can add COM_MESSAGES_SAVE_SUCCESS and there will be no need for JLIB_APPLICATION_SAVE_SUCCESS in com_messages.ini. But if we can't remove it now, we'll also have to add COM_ADMIN_SAVE_SUCCESS to com_admin.ini for now.
That the file is loading is fine (it's done by Actionlogs plugin) but it really shouldn't be overriding main library strings.
JLIB strings in specific component strings were designed to override the main lib.joomla.ini strings on purpose.
This situation is indeed created by the new Actionlogs plugin.
At first sight, it does not look like creating a specific string in com_messages.ini and deleting the JLIB one would create any issue.
Evidently that would mean adding a save method in the user controller.
No changes needed in controller, it supports string prefixes.
ah.. right.
Therefore no problem to add the string COM_MESSAGES_SAVE_SUCCESS and kill the JLIB one
| Status | New | ⇒ | Confirmed |
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-05 10:17:35 |
| Closed_By | ⇒ | SharkyKZ |
| Closed_By | SharkyKZ | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @SharkyKZ by The JTracker Application at issues.joomla.org/joomla-cms/28934
Please test PR #28939.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28934.
@infograf768 can we remove
JLIB_APPLICATION_SAVE_SUCCESSfromcom_messages.iniat this point or will this have to wait for 4.0?