NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
3 May 2020

Pull Request for Issue # .

Summary of Changes

Add loading=lazy for the drag&dropped images in tinyMCE

Testing Instructions

Apply the patch
Run npm ci

Create a new article, and add an image with drag and drop to editor (editor needs to be set to tinyMCE, it's the default)

Add a title and some dummy content

Save and publish the article

Observe the article in the frontend with the browser's tools and check that the image has an attribute loading="lazy"

Expected result

Actual result

Documentation Changes Required

This is a system wide change, meaning that the documentation will reflect all these changes (eg nothing special for this instance)

@wilsonge

avatar dgrammatiko dgrammatiko - open - 3 May 2020
avatar dgrammatiko dgrammatiko - change - 3 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2020
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 3 May 2020
The description was changed
avatar dgrammatiko dgrammatiko - edited - 3 May 2020
avatar brianteeman
brianteeman - comment - 3 May 2020

did you actually check this? because currently that drag and drop doesnt work

avatar dgrammatiko
dgrammatiko - comment - 3 May 2020

did you actually check this

Obviously not. Let me run the code then

avatar brianteeman
brianteeman - comment - 3 May 2020

See the release blocker issue #27477

avatar dgrammatiko
dgrammatiko - comment - 4 May 2020

Fixed at #28928

avatar dgrammatiko dgrammatiko - change - 4 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-04 12:14:31
Closed_By dgrammatiko
Labels Added: NPM Resource Changed ?
avatar dgrammatiko dgrammatiko - close - 4 May 2020

Add a Comment

Login with GitHub to post a comment