Feeling Lucky
?
?
[#28911] - [4.0] Fix login alert in footer
- Fixed in Code Base
- 3 May 2020
- Medium
- Build: 4.0-dev
- # 28911
- Diff
- Quy:28909-login
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28909.
Summary of Changes
Move login alert to the top.
Testing Instructions
Apply PR.
Log in to the backend with wrong credentials.
See that the login alert is at the top and not in the footer.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
SharkyKZ
- comment
- 2 May 2020
Can you do the same for error_full.php? And remove SCSS for notify-alerts class.
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) Front End Templates (site) |
richard67
- comment
- 2 May 2020
I have tested this item
Change in login.php tested as described.
Changes in error_full.php and the scss files: Code review. Verified that the "notify-alerts" class is not used anymore in any php or js or (s)css with this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28911.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 3 May 2020
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28911.
infograf768
- comment
- 3 May 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28911.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-03 06:29:43 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 3 May 2020
tks
I have tested this item✅ successfully on 25162c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28911.