? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
2 May 2020

Pull Request for Issue #28896 .

Summary of Changes

Fixes the ability to rename a file in media manager. This was broken in #28896 and was shows by the drone tests failing - unfortunately I still merged it anyway :)

Testing Instructions

Before patch check renaming a file with a new name gives a success message but it isn't actually renamed

Check that renaming a file to a different name works (also test that renaming a file and hitting save without saving it also works (i.e. gives a successfully renamed message).

Also check drone now passes

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 2 May 2020
avatar wilsonge wilsonge - change - 2 May 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2020
Category Administration com_media
avatar wilsonge wilsonge - change - 2 May 2020
The description was changed
avatar wilsonge wilsonge - edited - 2 May 2020
avatar wilsonge wilsonge - change - 2 May 2020
The description was changed
avatar wilsonge wilsonge - edited - 2 May 2020
avatar dgrammatiko
dgrammatiko - comment - 2 May 2020

I think you need the newAdapter there, otherwise this is fine,

PS ignore me this is fine

avatar richard67
richard67 - comment - 2 May 2020

@wilsonge What means "hitting save without saving it" in the testing instructions? Or did you maybe mean "hitting save without renaming it"?

avatar richard67
richard67 - comment - 2 May 2020

I have tested this item successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

avatar richard67
richard67 - comment - 2 May 2020

I have tested this item successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

avatar richard67 richard67 - test_item - 2 May 2020 - Tested successfully
avatar Quy
Quy - comment - 2 May 2020

I have tested this item successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

avatar Quy Quy - test_item - 2 May 2020 - Tested successfully
avatar Quy Quy - change - 2 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

avatar obuisard
obuisard - comment - 2 May 2020

I have tested this item successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

avatar obuisard obuisard - test_item - 2 May 2020 - Tested successfully
avatar richard67 richard67 - change - 2 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-02 19:18:34
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 2 May 2020
avatar richard67 richard67 - merge - 2 May 2020
avatar richard67
richard67 - comment - 2 May 2020

Thanks to all.

Add a Comment

Login with GitHub to post a comment