Feeling Lucky
?
[#28887] - [3.x] Contact Address
- Closed
- 30 Apr 2020
- Medium
- Build: staging
- # 28887
- Diff
- brianteeman:address
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The check to see if the address should be displayed for a contact takes place inside the definition list. This means that you get an empty dl if you have chosen not to display the address.
This PR corrects that and moves the dl inside the if statement
Testing Instructions
Code review and checking the generated markup of the contact component when the address is displayed and when it is not.
Expected result
The empty dl will be removed if there is no address being displayed
Backwards Compatibility
I can't imagine any bc issues other than potentially removing some white space
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-30 22:21:06 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 72d1e01
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28887.