[#28886] - [4.0] Media Manager Events correctly triggered
- Fixed in Code Base
- 24 May 2020
- Medium
- Build: 4.0-dev
- # 28886
- Diff
- dgrammatiko:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issues #28877 #28878
Summary of Changes
Refactor the Model to trigger the correct Events with the correct payload for files/folders created/updated/deleted
Testing Instructions
Download install and enable the following plugin
mediamanagertest.zip
Test steps:
- Upload a file in the media manager
- Delete the file you just uploaded
- Edit the image you just uploaded, eg crop it
- Create a folder
- Delete the newly created folder
Check plugins/content/mediamanagertest for a file log.txt the contents should be like
File uploaded
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"Screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":true}
-------------------------
-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"Screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":true}
-------------------------
File updated
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":false}
-------------------------
-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"screenshot 2020-04-29 at 19.22.58.png","path":"\/","new":false}
-------------------------
File Deleted
-------------------------
Event Type: onContentBeforeDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/screenshot.png"}}
-------------------------
-------------------------
Event Type: onContentAfterDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/screenshot.png"}}
-------------------------
Folder Created
-------------------------
Event Type: onContentBeforeSave
Event Payload: {"adapter":"local-0","name":"test","path":"\/","new":true}
-------------------------
-------------------------
Event Type: onContentAfterSave
Event Payload: {"adapter":"local-0","name":"test","path":"\/","new":true}
-------------------------
Folder Deleted
-------------------------
Event Type: onContentBeforeDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/test"}}
-------------------------
-------------------------
Event Type: onContentAfterDelete
Event Payload: {"data":{"adapter":"local-0","path":"\/test"}}
-------------------------
Expected result
Actual result
Documentation Changes Required
No, bug fix
Remarks:
- Moving/copying files won't trigger any event. This is kinda awkward...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Labels |
Added:
?
|
||
@infograf768 partly.
Also, internal server error when saving name of file or folder.
This should be ok now. Reason was that one of the current events had a wrong signature (expected to be called with 4 params but was called with 3)
Ref: #28886 (comment) & #28842 (comment)
I still get the Internal Server Error when saving the file with the same name. It's OK when modifying the name of the file.
I still get the Internal Server Error when saving the file with the same name
Sorry I misunderstood, I was talking about renaming to something different.
Still wrong.
I have not tested this item.
@dgrammatiko I installed the plugin and function. Subsequently I looked for the log.txt file that you describe, but I did not find it .... I only have the indication of User Action Log. Where is the file?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.
I looked for the log.txt
it is created in the plugin's folder: plugins/content/mediamanagertest
Apply PR it all worked out. Going to Latest actions (from home dashboard) and clicking on the name of the uploaded image, I have error 0
so it's only a problem related to the com_actionlogs ?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28886.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-24 23:45:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Now Media Action - Resize plugin doesn't work.