J4 Issue ?
avatar richard67
richard67
29 Apr 2020

Steps to reproduce the issue

Update a clean 3.10-dev to 4.0-dev nightly.

Login to backend and check the error alert which is shown.

Then goto "System - Information Database" and check the tooltip shown when hovering over the "One Problem" badge for the CMS.

Expected result

After login to backend, only the usual error is shown:
j4-update-from-3-10_normal-template-error.

In "System - Information Database", only the errors marked with a green frame in the 2nd image in section "Actual result" are shown, but not the one marked with the red frame in the same image.

Actual result

After login to backend, not only the usual error is shown:
j4-update-from-3-10_finder-tables-errors.

In "System - Information Database":
j4-update-from-3-10_db-checker.

The errors marked with the green frame are not related to this issue here, they belong to issue #28530 and will be solved when the changes from my PR #28501 will be merged up into 4.0-dev.

The error about database not having been converted to utf8mb4 marked with the red frame is related to this issue here, see section "Additional comments" below for the explanation.

System information (as much as possible)

Happens only with MySQL or MariaDB.

Additional comments

The problems comes from recent changes for the utf8mb4 conversion (PR #28495 ) having been merged up into 3.10-dev already but not yet into 4.0-dev.

The changes in 3.10-dev not being in 4 yet make the utf8mb4 conversion run when doing the update, which should not be the case of course. And this then unmasks other errors which haven't been noticed before and which will be fixed with my PR #28515 (or a new later PR as replacement for that). And so the unneccesary utf8mb4 conversion fails, and the database checker shows this as an error.

So this issue is just for documentation of the issue, the fix is already on the way.

I only wait for the changes from staging being merged up. Alternatively, if that takes too long, I can do the same changes here in 4.0-dev. but this will then cause merge conflicts later for the merge up.

@wilsonge Let me know what you prefer: Wait for your merge, or fix it in J4 and cause later merge conflicts for you (but in that case I will help to solve them if necessary, of course).

avatar richard67 richard67 - open - 29 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2020
avatar richard67 richard67 - change - 29 Apr 2020
Labels Added: ?
avatar richard67 richard67 - labeled - 29 Apr 2020
avatar richard67 richard67 - change - 29 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 29 Apr 2020
avatar richard67 richard67 - change - 29 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 29 Apr 2020
avatar richard67 richard67 - unlabeled - 29 Apr 2020
avatar richard67 richard67 - labeled - 29 Apr 2020
avatar richard67
richard67 - comment - 29 Apr 2020

Changing from beta blocker to release blocker because the database isn't really broken, just the database checker shows wrong errors, similar as in issue #28530, which is also a release blocker.

avatar richard67 richard67 - change - 29 Apr 2020
Labels Added: ?
Removed: ?
avatar richard67 richard67 - change - 29 Apr 2020
Labels Added: ?
Removed: ?
avatar richard67 richard67 - unlabeled - 29 Apr 2020
avatar richard67 richard67 - labeled - 29 Apr 2020
avatar richard67 richard67 - change - 29 Apr 2020
Labels Added: ?
Removed: ?
avatar richard67 richard67 - unlabeled - 29 Apr 2020
avatar richard67 richard67 - labeled - 29 Apr 2020
avatar richard67
richard67 - comment - 29 Apr 2020

Now the issue tracker shows the right labels, too.

avatar richard67 richard67 - change - 29 Apr 2020
Build staging 4.0-dev
avatar richard67 richard67 - change - 29 Apr 2020
Labels Added: J4 Issue
avatar richard67 richard67 - labeled - 29 Apr 2020
avatar richard67
richard67 - comment - 1 May 2020

Update: No need to wait for merge from changes in staging up to 4.0-dev. My PR #28515 will fix this issue here, it is just still WiP, so I leave this issue open.

avatar richard67
richard67 - comment - 1 May 2020

My PR #28515 is ready for test now.

Closing as having PR.

avatar richard67 richard67 - close - 1 May 2020
avatar richard67 richard67 - change - 1 May 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-05-01 16:24:12
Closed_By richard67
avatar richard67
richard67 - comment - 11 May 2020

Update for documentation purpose: This issue is not solved with my PR #28515 mentioned above, it is already solved without that PR since the recent upmerge from the 3.10-dev branch to 4.0-dev. But the PR is still necessary for other reasons.

avatar wilsonge wilsonge - change - 16 Sep 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 16 Sep 2020

Add a Comment

Login with GitHub to post a comment