[#28872] - When viewing the Settings of some component, ensure that hitting "Cancel" redirects back to the specific URL the user was previously on
- Closed
- 12 Jun 2022
- Medium
- Build: staging
- # 28872
- Diff
- fevangelou:staging
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28871
Summary of Changes
Steps to reproduce the original bug:
- Hit the "Settings" toolbar button on any component (let's call it com_X) and you get redirected to the component's settings, loaded via com_config.
- If you hit "Save & Close" you get redirected back to the exact URL you previously were on com_X.
- If you hit "Cancel" you are redirected back to the component's main page (index.php?com_X) and NOT to the page you were in that component.
This PR properly adapts the code to respect the "return" variable (if it exists) and redirect back to the exact URL the user was on if they hit "Cancel".
Testing Instructions
Expected result
Actual result
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Labels |
Added:
?
|
||
Formatio-hippocampi
- 
Session data is still not being cleared.
Why does that matter exactly?
On Tue, Sep 8, 2020, 10:37 AM SharkyKZ notifications@github.com wrote:
Session data is still not being cleared.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#28872 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ52G22EMPXMVRKCYX367DSEXNKVANCNFSM4MT2N27Q
.
We don't want old form data lingering in session. Cancel task should clear the data and perform the redirect. Also because com_config is broken in some ways, this introduces an issue of component's form data appearing in Global Configuration.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28872.
I agree that this is an issue that should be fixed but I would propose to fix this issue within 4.2 and not change this within the 3.10 livetime. will close this PR please create a new pr against 4.2-dev so we get testers and fixed within j4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 17:43:55 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item✅ successfully on 86a9356
option=com_fields&view=fields&context=com_content.articleOptionsCancel-- Without PR redirect to
option=com_content,-- with PR redirect to
option=com_fields&view=fields&context=com_content.articleThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28872.