? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
27 Apr 2020

This PR adds validation to parameter fields of type=option to the parameters of .xml files back-end Modules

I've added

validate="options"

to all fields of type=list with defined options

avatar pe7er pe7er - open - 27 Apr 2020
avatar pe7er pe7er - change - 27 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2020
Category Modules Administration
avatar carcam carcam - test_item - 30 Apr 2020 - Tested successfully
avatar carcam
carcam - comment - 30 Apr 2020

I have tested this item successfully on f6528b5

I have tested this PR following these instructions:

  1. Go to module manager
  2. Filter to see admin modules
  3. Create a new custom module
  4. Go to advanced tab and choose a caching option (no caching for instance)
  5. Inspect the html of that option with your browser and change the number to a random one (42 for instance)
  6. Click on save

Result before Patch

You are allowed to save the module

Result after Patch

You are not allowed to save the module and an error message appears informing about the error in the cache field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28830.

avatar luisorozoli
luisorozoli - comment - 30 Apr 2020

I have tested this item successfully on f6528b5

Tested successfully in launch joomla in J4. :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28830.

avatar luisorozoli luisorozoli - test_item - 30 Apr 2020 - Tested successfully
avatar Quy Quy - change - 30 Apr 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28830.

avatar Quy Quy - change - 30 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-30 15:54:02
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 30 Apr 2020
avatar Quy Quy - merge - 30 Apr 2020

Add a Comment

Login with GitHub to post a comment