? ? Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
27 Apr 2020

This PR adds validation to parameter fields of type=option to the parameters of .xml files front-end Modules

I've added

validate="options"

to all fields of type=list with defined options

avatar pe7er pe7er - open - 27 Apr 2020
avatar pe7er pe7er - change - 27 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2020
Category Modules Front End
avatar jwaisner
jwaisner - comment - 27 Apr 2020

@pe7er Can you please provide test instructions for this PR?

avatar brianteeman
brianteeman - comment - 27 Apr 2020

@jwaisner The testing is by code review which should be obvious

avatar jwaisner
jwaisner - comment - 28 Apr 2020

@brianteeman I appreciate the clarification. However I do not appreciate the assumption that everyone understands all coding language.

avatar pe7er
pe7er - comment - 28 Apr 2020

@jwaisner Sorry, I should have added a testing instruction that it could be tested with a code review.

avatar ChristineWk ChristineWk - test_item - 2 May 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 2 May 2020

I have tested this item successfully on 614ab18

long list :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28829.

avatar Quy Quy - test_item - 2 May 2020 - Tested successfully
avatar Quy
Quy - comment - 2 May 2020

I have tested this item successfully on 614ab18


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28829.

avatar Quy Quy - change - 2 May 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 May 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28829.

avatar wilsonge wilsonge - change - 8 May 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-05-08 22:38:23
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 8 May 2020

Thanks!

Add a Comment

Login with GitHub to post a comment