[#288] - Adding viewname to menuitems manager
- Closed
- 17 Aug 2013
- Medium
- Build: master
- # 288
- Diff
- Bakual:MenuManager
User tests: Successful: Unsuccessful:
The "Menu Manager: Menu Items" view currently shows the "Menu Item Type" as
"component" » "layout"
This commit will add the viewname to it as set in the metadata.xml:
"component" » "view" » "layout"
Interesting enough the code currently requires the file present and this title set, but doesn't use it. So it's probably just an oversight.
This commit will also use the "message" set in the metadata.xml as fallback for the item type description if there is no "message" set in the layout file.
Aww, didn't notice that. And there I was thinking it would be a simple and easy change.
Would that go into the feature tracker or into the bug tracker?
Another approach would be to either show the view title or the layout title. Taking the view title as fallback for the layout. This way the text shouldn't get to long and break the manager display. I would prefer to show the view always like it was in Joomla 1.5 but I think both ways would work.
Currently it just makes no sense to have a title in metadata.xml at all. It gets checked in menumanager but isn't used for anything. Either make it completely optional or use the info somewhere :-)
- Made the title in the metadata.xml optional. Only showing it when it's set.
- Deleted the title and message from the view metadata.xml in the core where they were not translated.
This way nothing should change for the core, but an extension developer can decide to show the viewname in the menumanager by setting it in the metadata.xml.
I guess this makes most sense.
Trackitem on Feature Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28860
Added patchfile and test instructions to feature tracker.
Closing as no activity
The "view" is not translated in default Joomla.
Articles » ??Article?? » Single Article
This means new language strings:
On a default sample data core install:
ARCHIVE="Archive"
ARTICLE="Article"
CATEGORY="Category"
COM_FINDER_MENU_SEARCH_VIEW_TITLE="FINDER MENU SEARCH VIEW TITLE"
COM_NEWSFEEDS_CATEGORY_GROUP_LABEL="NEWSFEEDS CATEGORY GROUP LABEL"
CONTACT="Contact"
FORM="Form"
FRONTPAGE="Frontpage"
LOGIN="Login"
NEWSFEEDS_NEWSFEED_INDIVIDUAL_FEED_LABEL="NEWSFEED INDIVIDUAL FEED LABEL"
PROFILE="Profile"
REGISTRATION="Registration"
REMIND="Remind"
RESET="Reset"
SEARCH="Search"
Also, it breaks the manager display when the "view" text is too long.
If we implement this, we should only for 3.0 as this would require new constants in all metadata.xml + new strings.
Please open a tracker on joomlacode and cross reference here.