? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
25 Apr 2020

Pull Request for Issue #28663

Summary of Changes

Changed the main color preset to match the new light blue color better.
I see that the previoused chosed color was probably chosen by monochromatic approch with a lighter shade of the monochromatic matching color, but it did not match the color harmony of the light blue color that good. So I used a color mix between black and the light blue to get some more exe candy.

grafik

Testing Instructions

Apply the patch and reset the hue setting in the Backend Template Atum Style for the dark colour

Expected result

The backend top bar should change to hex #132f53
it should look nicer now

Documentation Changes Required

no

Additional Information

Next step could be to remove the hue settings and calculations at all because they were actually only made for the dark themed sidebar that is gone now. I can open a RFC for this.

avatar coolcat-creations coolcat-creations - open - 25 Apr 2020
avatar coolcat-creations coolcat-creations - change - 25 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2020
Category Unit Tests Repository Administration
avatar roland-d
roland-d - comment - 25 Apr 2020

@zero-24 How can we restart the tests against the new base branch?

avatar zero-24
zero-24 - comment - 25 Apr 2020
avatar roland-d
roland-d - comment - 25 Apr 2020

@zero-24 It says it is running against staging
image
That can't be right and it failed.

avatar zero-24 zero-24 - change - 25 Apr 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2020
Category Unit Tests Repository Administration Administration Templates (admin)
avatar zero-24 zero-24 - change - 25 Apr 2020
Labels Added: ?
Removed: ?
avatar zero-24
zero-24 - comment - 25 Apr 2020

Lets see whether it works now :)

avatar zero-24
zero-24 - comment - 25 Apr 2020
avatar richard67 richard67 - change - 25 Apr 2020
Build staging 4.0-dev
avatar ChristineWk
ChristineWk - comment - 25 Apr 2020

OT: @richard67 completely fresh (nightly) installation from today :-)
@coolcat-creations Hi Elisa:
Choose your hue value for the dark template colour
Before Patch: > 207
After Patch: > 214
That's correct now & successful?
Under template.min.css I didn't find #132f53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28780.

avatar brianteeman
brianteeman - comment - 25 Apr 2020

NOTE if you have ever saved the template style then this PR will not update the saved param value of 207. You will need to open the template style and either change it to 214 and save OR just delete the 207 and save

avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2020

@ChristineWk seems successful, like @brianteeman just said, delete the value in the hue slider and save. The Topbar should look better now in combination with the link colour. See the third colour combination in my initial post.

avatar ChristineWk
ChristineWk - comment - 25 Apr 2020

I have tested this item successfully on 14e5804


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28780.

avatar ChristineWk ChristineWk - test_item - 25 Apr 2020 - Tested successfully
avatar wilsonge wilsonge - change - 25 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-25 12:50:38
Closed_By wilsonge
Labels Removed: ?
avatar wilsonge wilsonge - close - 25 Apr 2020
avatar wilsonge wilsonge - merge - 25 Apr 2020
avatar wilsonge
wilsonge - comment - 25 Apr 2020

Thankyou!

Add a Comment

Login with GitHub to post a comment