? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 Apr 2020

Summary of Changes

As done in 3.x, this PR hardcodes the name of the installation folder to prevent translating it.
See code change

Testing Instructions

Patch and install J4

After PR

Screen Shot 2020-04-22 at 09 06 32

Screen Shot 2020-04-22 at 09 06 17

Note

Still remains in the installation ini files 4 strings containing the wording installation folder.
They are not used in J4 at this time but may be in the future. Therefore I have not deleted them.
The decision about them should be taken during beta phase.

@brianteeman

avatar infograf768 infograf768 - open - 22 Apr 2020
avatar infograf768 infograf768 - change - 22 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2020
Category Installation Language & Strings JavaScript
avatar brianteeman
brianteeman - comment - 22 Apr 2020

LGTM I didnt notice that this had not made it from 3.x

avatar brianteeman
brianteeman - comment - 22 Apr 2020

I have tested this item successfully on 937ab82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28752.

avatar brianteeman brianteeman - test_item - 22 Apr 2020 - Tested successfully
avatar Quy
Quy - comment - 22 Apr 2020

I have tested this item successfully on 937ab82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28752.

avatar Quy Quy - test_item - 22 Apr 2020 - Tested successfully
avatar Quy Quy - change - 22 Apr 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28752.

avatar richard67 richard67 - change - 22 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-22 16:23:59
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 22 Apr 2020
avatar richard67 richard67 - merge - 22 Apr 2020
avatar richard67
richard67 - comment - 22 Apr 2020

Thanks.

Add a Comment

Login with GitHub to post a comment