Feeling Lucky
NPM Resource Changed
?
?
[#28710] - [4.0] Javascript - destruct params
- Fixed in Code Base
- 9 May 2020
- Medium
- Build: 4.0-dev
- # 28710
- Diff
- C-Lodder:js-stuff-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Just some minor JS improvements to use parameter destructing.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
C-Lodder
- comment
- 17 Apr 2020
Babel transpiles destructing params by default. This isn't a DOM method.
No need to use rollup at all.
roland-d
- comment
- 18 Apr 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28710.
anibalsanchez
- comment
- 2 May 2020
I have tested this item
Test OK
The build script transpile the parameter destructing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28710.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 2 May 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28710.
wilsonge
- comment
- 9 May 2020
Can you fix conflicts here please - it's from the install from web pr you did
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-09 10:37:19 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 9 May 2020
Thanks!
@C-Lodder you cannot introduce such ES2015+ options without a way to compose ES5 compatible scripts. In short you need to pump (eg use rollup) the build tools if you still care for ES5. I'm guessing the project neither cares about ES5 or any js version other than the latest ES20**..
Not a wise choice (just an opinion from an old guy...)