? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Apr 2020

Pull Request for Issue #28623 .

Summary of Changes

Improve asset registry files handling, and fix asset loading on administrator error page

Testing Instructions

add an exception onAfterInitialise event, eg place it in system/sef plugin:

public function onAfterInitialise()
{
  throw new Exception('that an error!!');
}

And go to administrator side.

Expected result

You should get error page from the template

Actual result

An error that some asset not exits

ping @wilsonge

avatar Fedik Fedik - open - 11 Apr 2020
avatar Fedik Fedik - change - 11 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Category Libraries
avatar fancyFranci
fancyFranci - comment - 11 Apr 2020

I can not reproduce the problem :/
I get the error page without asset problems when I follow the instructions. No console or network errors too.
screen shot 2020-04-11 at 14 02 12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28636.

avatar ggenovino
ggenovino - comment - 11 Apr 2020

I got the same results as fancyFranci

avatar Fedik
Fedik - comment - 11 Apr 2020

Please do test on latest 4.0-dev branch,
your screenshot from very old Dev version

avatar wilsonge
wilsonge - comment - 11 Apr 2020

I have tested this item successfully on d30d12a

Added error into SEF plugin:

Before Patch: screen shot 2020-04-11 at 21 01 36

After Patch: screen shot 2020-04-11 at 21 01 38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28636.

avatar wilsonge wilsonge - test_item - 11 Apr 2020 - Tested successfully
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge wilsonge - change - 11 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 21:29:33
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment