[#28635] - [4.0] Defer loading of menu items until required
- Fixed in Code Base
- 11 Apr 2020
- Medium
- Build: 4.0-dev
- # 28635
- Diff
- wilsonge:feature/defer-menu-load
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28614 .
Summary of Changes
Defers loading of the menu items until we actually need the information on the menu items. In certain cases this will mean that
Testing Instructions
- Ensure menus load in the frontend on a normal single language site
- Ensure menus load in the frontend on a multilanguage site
- Ensure menus load in the backend
- Update Joomla from 3.10 (multilanguage site) using the PR custom update site to this branch. It should now work after this patch.
Documentation Changes Required
Yes. Document menu items are being loaded later. This will only be relevant however for custom menus extending Joomla\CMS\Menu\AbstractMenu so should be an edge case.
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Libraries |
btw it seems that we have still an issue with PDO cause have worked even before this pr
so we still have soemething to fix on the PDO drivers
I have tested this item
Tested on:
dbtype mysqli
Database Type mysql
Database Version 10.1.43-MariaDB
Database Collation utf8_general_ci
Database Connection Collation utf8mb4_general_ci
Database Connection Encryption None
Database Server Supports Connection Encryption No
PHP Version 7.3.12
Web Server Apache
WebServer to PHP Interface fpm-fcgi
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635.
I have tested this item
Solves isssue for sqli as well as sql(PDO)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635.
That's one of the PR's (update tests) where I am really happy about the update packages built by drone for this PR. In pasz I had to build them myself "manually".
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-11 09:19:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thankyou guys!
Thank you guy
drone and appveyor both failing.
hard to figure what's going on...
Appveyor is a known issue ... Hannes is on it.
Drone seems to be the regular randomly happening timeout. We will see.
I have tested this item✅ successfully on f971e00
with mysql 8.0.19 and postgresql
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28635.