User tests: Successful: Unsuccessful:
Table extension got a new column proctected.
This PR fixes a bug in the view - the field name is protected, not locked
And concatenates two columns to reduce the number of columns.
Set error-reporting to "developent" and go to extensions manage.
You will see a warning in column locked and two columns for version and date.
No warning
and a screen like this:
screen
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer |
Title |
|
||||||
Labels |
Added:
?
|
||||||
Easy | No | ⇒ | Yes |
Title |
|
Title |
|
I have tested this item
I didn't get the warning but the gui work correctly.
BEFORE
AFTER
See #28614 (comment) possibly due to upgrading from v3.10. Please try with a clean install.
1st test, see previous post.
2nd rest: I also tried with the new Patch tester. Loaded:
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/28612/downloads/31081/ from above Download (Prebuilt package) and also
Server: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/28612/downloads/31081/pr_list.xml
System: 4.0.0-2020-03-25 | 4.0.0-beta1-dev+pr.28612 |
---|
Now checked again (without Patch). No warning. It looks like:
Why version and date in the same column?
It's wrong.
They are two different type of data, and two different type of information that an admin user can read (and maybe select and export).
Not happy with mixing different data.
Maybe, you can try to add, like many others apps and cms, a "show columns" settings if "some" have problem with many columns in a table. Not by deleting columns and mixin data.
And date, need to be orderable, to rapidly check if we have "not maintained" extensions.
Maybe, you can try to add, like many others apps and cms, a "show columns" settings if "some" have problem with many columns in a table. Not by deleting columns and mixin data.
See #27956
And date, need to be orderable, to rapidly check if we have "not maintained" extensions.
As you can see in the screen shot Date
is not a reliable field for ordering because it's the creationDate
in manifests and Joomla uses strings like "July 2006" (whyever it's not a full, easy-to-order date). I use strings like "2016-12-30". Others use other format.
The same with version
. it's not forbidden to use version strings like "2019.10.28" even if it's not an academically correct version string for nerds.
Maybe, you can try to add, like many others apps and cms, a "show columns" settings if "some" have problem with many columns in a table. Not by deleting columns and mixin data.
See #27956
Very nice! This is a good, logic and really usable solution. Can be refined but it is the right direction.
And date, need to be orderable, to rapidly check if we have "not maintained" extensions.
As you can see in the screen shot date is not a reliable field for ordering because it's the
creationDate
in manifests and Joomla uses strings like "July 2006" (whyever). I use strings like "2016-12-30". Others use other format.The same with
version
.
This is a "standard" problem, the xml field must give an error if a date in not written in an a accepted format.
This is a "standard" problem, the xml field must give an error if a date in not written in an a accepted format.
And I say: NO. Do you really want to annoy 3rd developers with new nerdy rules for nothing.
And you're ignoring the fact that the creationDate is the date when the first version of an extension was created. Not the date of the last version!
And as you can see the extension versions in Joomla, e.g. 3.0.0
never changed, even if the extension code was changed over the years several times.
I have tested this item
I cant see the warning either. Can you only see it in a special system environment?
I would also find it better if the values remained in different columns.
This are my system information:
php: Linux astrid-TravelMate-5760G 4.15.0-96-generic #97-Ubuntu SMP Wed Apr 1 03:25:46 UTC 2020 x86_64
dbserver: mysql
dbversion: 5.7.29-0ubuntu0.18.04.1
dbcollation: utf8mb4_unicode_ci
dbconnectioncollation: utf8mb4_general_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.2.29-1+ubuntu18.04.1+deb.sury.org+1
server: Apache/2.4.29 (Ubuntu)
sapi_name: apache2handler
version: Joomla! 4.0.0-beta1-dev Development [ Mañana ] 17-October-2019 20:21 GMT
useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0
@simbus82 as long as we don't have the possibility to hide columns (I agree with you that this is a very desirable feature) , I think it is better to combine Information which is just infromation and give more place for other fields (name of the extension, for exaample. Version and date of release are no odering fields and no links, and in my opinion they are self explainig.
@astridx and @ChristineWk and others, finally after new clone, deleting the database and re-builing the whole environment - the notice has gone. Tahnk you all!
I have tested this item
I have tested this item successfully,
result: No warning and a screen like yuor
I do see the warning on a git checkout version of Joomla 4. I had to Fix the Database structure and then all is good. The locked
field is new for the extensions
table.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-19 13:13:07 |
Closed_By | ⇒ | chmst |
@chmst Didn't get the warning. Error reporting to development on. OT: See info at forum de. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28612.