User tests: Successful: Unsuccessful:
This namespaces the JHtml helpers as agreed by Production. Fixes #28249
error_login.php
file of atum that I discovered whilst doing this where we could double register a html serviceNamespaces JHtml classes. Note the two classes that are new for J4 (workflowstages and draggable do not have namespace mappings created as they are new for j4)
Ensure CMS works as before in a variety of frontend and backend views
If you are technical review class names make sense - as they aren’t tied to the name being called they can be made longer without any affect
Yes. If you are overriding JHtml methods you can no longer use \Joomla\CMS\HTML\HTMLHelper::register()
you now must instead use
\Joomla\CMS\HTML\HTMLHelper::getServiceRegistry()->register('jquery', 'MyCustomClass', true);
The last parameter $replace
is the important part :) Note that this means you can only override the entire Helper. You can't overload a specific function after this change. In the two cases where people regularly do this in the ecosystem (bootstrap and jquery) this isn't really an issue:
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Administration Templates (admin) Libraries |
Labels |
Added:
?
|
Tagged as beta blocker
Priority | Medium | ⇒ | Urgent |
I have tested this item
Tested frontend and backend. No issues found. Did not have overrides in place.
I have tested this item
Also tested frontend and backend without having any overrides in place.
I hope I haven't forgotten anything.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-11 09:12:59 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
?
?
|
Ok merging as a first pass. Agree with ListHelper but willing to take followups if anyone comes up with something better
@wilsonge PHPCS