[#28580] - [4.0] Remove a "development" error_reporting as obsolete
- Fixed in Code Base
- 11 Apr 2020
- Medium
- Build: 4.0-dev
- # 28580
- Diff
- Fedik:remover-error-dev-reaporting
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove a "development" error_reporting from configuration, as obsolete.
Since php 5.4 error_reporting(-1) and error_reporting(E_ALL) have the same behavior.
See https://www.php.net/manual/en/function.error-reporting
Passing in the value -1 will show every possible error, even when new levels and constants are added in future PHP versions. The E_ALL constant also behaves this way as of PHP 5.4.
Testing Instructions
Code review.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings |
hm yeap,
a little drawback
| Labels |
Added:
?
?
|
||
okay, I made the option disabled, instead of fully removing, for now. It can be removed in future 4.x
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28580.
Rather than leaving the option in the list override getData https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_config/src/Model/ApplicationModel.php#L81 similar to what we did for the DB driver being used. Remove the option from the form field - leave the handling code in include.php
I have tested this item
Tested in beta1-dev 20200409
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28580.
I have remove the option from the form, and made override for old value in the model.
Please retest.
I have tested this item
Tested in beta1-dev of 20200411
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28580.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-11 21:29:12 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item? unsuccessfully on 44da919
If your site is set to development before you upgrade (or for testing before you apply this PR) then the configuration.php will still say
public $error_reporting = 'development';but joomla says system default
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28580.