? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Apr 2020

It is perfectly valid to have a dotless email address eg brian@example and all our validation rules allow it.

phpmailerdefaults to use PHP built-in FILTER_VALIDATE_EMAIL but this does not support dotless domain names

This PR removes an outdated comment and sets the validtop
r to be html5. This is the same validator used when submitting an email address and supports dotless domains.

The easiest way to test this is with the global config

Set the from email to anything@example and then click the send test mail button

You will get an error message Invalid address (to): anything@example

Apply this PR and you no longer get the error

Pull Request for Issue #27948

avatar brianteeman brianteeman - open - 4 Apr 2020
avatar brianteeman brianteeman - change - 4 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2020
Category Libraries
avatar brianteeman
brianteeman - comment - 4 Apr 2020

If confirmed as correct then this needs to be backported to joomla 3

avatar brianteeman brianteeman - change - 4 Apr 2020
Labels Added: ?
avatar ChristineWk
ChristineWk - comment - 6 Apr 2020

I have tested this item successfully on fafcc86

After changing to dotless: Mail accepted. No error message > OK.
But test-mail has not been sent. > ?
Back to origin: it has been sent.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28574.

avatar ChristineWk ChristineWk - test_item - 6 Apr 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Apr 2020

I have tested this item successfully on fafcc86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28574.

avatar jwaisner jwaisner - test_item - 10 Apr 2020 - Tested successfully
avatar jwaisner jwaisner - change - 10 Apr 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 10 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28574.

avatar wilsonge wilsonge - close - 10 Apr 2020
avatar wilsonge wilsonge - merge - 10 Apr 2020
avatar wilsonge wilsonge - change - 10 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-10 23:15:05
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 10 Apr 2020

Thanks!

avatar brianteeman
brianteeman - comment - 10 Apr 2020

thanks

Add a Comment

Login with GitHub to post a comment