[#28573] - Add HTML5 elements and WAI-ARIA to error.php.
- Fixed in Code Base
- 7 Apr 2020
- Medium
- Build: staging
- # 28573
- Diff
- Harmageddon:protostar-error-html5-aria
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Original report by user Gerry77 at https://forum.joomla.de/thread/11519-protostar-footer-in-error-php-und-index-php-unterschiedlich/?postID=69810#post69810.
Summary of Changes
When comparing Protostar's error.php to index.php, you see that some changes like 1892d43 and #1037 have been made to index.php, but not to error.php. This PR adapts these changes to use HTML5 elements like footer and ARIA roles in the error.php, too.
Testing Instructions
Check the changed HTML output. Make sure that the display doesn't change on error pages (except maybe the "back to top" link working better now in some browsers).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28573.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28573.
richard67
- | Labels |
Added:
?
?
|
||
If I rightly remember, correct semantics don't require a role.
E.g <main> is already used as a landmark. So using role is unnecessary
They do for ie11 unfortunately
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-07 13:25:20 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
I have tested this item✅ successfully on e6ff72b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28573.