Feeling Lucky
NPM Resource Changed
?
[#28552] - [4.0] Remove "fs" from package.json
- Fixed in Code Base
- 8 Apr 2020
- Medium
- Build: 4.0-dev
- # 28552
- Diff
- C-Lodder:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
The File System API is already built into NodeJS, so it doesn't need to be defined as a dev dependency.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
C-Lodder
- comment
- 6 Apr 2020
@dgrammatiko Fs is being called from the native API. fs-extra isn't needed in this case. The PR is purely for removing the reference to it in the package.json because it's native to NodeJS
C-Lodder
- comment
- 8 Apr 2020
@wilsonge Just so you're aware, there's absolutely no code associated with this package:
https://www.npmjs.com/package/fs
It's a purely placeholder so that people who previously used it don't run into build errors.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-08 13:34:58 |
| Closed_By | ⇒ | wilsonge |
@dgrammatiko you added this in #19426 - this seems logical to me - but giving you the ability to comment first before i regret anything :)