? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 Mar 2020

Pull Request for Issue #28425 (comment).

Summary of Changes

Same as in PR #28425 but for the component-specific install sql.

This is not really used anymore but still shall be kept up-to-date according to @wilsonge 's comment here: #28425 (comment).

For PostgreSQL only comments and code style have changed so it is more equal to the corresponding section in the joomla.sql file.

Testing Instructions

Code review:

  • Compare the mysql/joomla.sql and the install.mysql.sql files and verify that beside comments and empty lines, the sections for creating com_finder tables in both files are the same.
  • Compare the postgresql/joomla.sql and the install.postgresql.sql files and verify that beside comments and empty lines, the sections for creating com_finder tables in both files are the same.
  • Verify that the changes in the install.XXX.sql files are basically the same as done in PR #28425 in the corresponding joomla.sql file.

Expected result

Files install.mysql.sql and install.postgresql.sql of com_finder are up-to-date with the changes in PR #28425 for joomla.sql.

Actual result

Files install.mysql.sql and install.postgresql.sql of com_finder are not up-to-date with the changes in PR #28425 for joomla.sql.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 25 Mar 2020
avatar richard67 richard67 - change - 25 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2020
Category Administration com_finder
avatar wilsonge wilsonge - change - 25 Mar 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-25 22:12:43
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Mar 2020
avatar wilsonge wilsonge - merge - 25 Mar 2020
avatar wilsonge
wilsonge - comment - 25 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment