[#28454] - [4.0] Fix styling of btn-group in RTL
- Fixed in Code Base
- 27 Mar 2020
- Medium
- Build: 4.0-dev
- # 28454
- Diff
- wilsonge:feature/rtl-btn-group
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Alternative PR to #28405
Summary of Changes
Whilst I don't mind removing the btn-group necessarily it made me realise the entire styling for it was broken in RTL when you had more than 1 item in the btn group. This fixes the btn group styling generally.
Testing Instructions
Check the btn-group class functions in both searchtools and in the versions modal. Version modal before and after as below (note the border-radius and the padding on the right hand button)
Before Patch
After Patch
Documentation Changes Required
None
cc @infograf768
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
done
This is what we get (after this patch) when we display the Associations Tab when editing an article for example (multilingual site)
It gets worse here with this patch for LTR
Sorry how does this patch make LTR worse?
OOps: I meant RTL.
But what we're saying is even thought there's a regression with RTL we now get parity between LTR and RTL?
@infograf768 i don't see any difference before and after the patch - that's using input-group not btn-group - all I've touched is button group. can you please show me what differences you are seeing before and after the patch
i don't see any difference before and after the patch
You are right. RTL buttons there have some left radius also before patch.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-27 11:19:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Merging this so it's in. But happy for you to continue working on the other patch still - this is still useful either way
the other patch for history is ready. It just needs a decision on the margins.
could you post screenshots please of the expected results