User tests: Successful: Unsuccessful:
Third PR for the Tracker: #32983
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32983&start=0
Isn't there a better way than to apply inline styles all over the place?
Also it will only work for core extensions. Each 3rd party would have to do the same as well to achieve a similar result.
I would prefer a more generic solution for this valid issue.
@Bakual Looks hard to make a generic solution as almost each batch is different.
We could get rid of the inline styles by using classes
@zero-24
I suggest to make sure you do not forget some batch actions (see Newsfeeds where language is missing in PR) and try to order the batch actions in the same way all over for those present.
Played around a bit. Have a look at this approach (used com_content):
<div class="modal-body row-fluid">
<p class="span12"><?php echo JText::_('COM_CONTENT_BATCH_TIP'); ?></p>
<div class="row-fluid">
<div class="control-group span6">
<div class="controls">
<?php echo JHtml::_('batch.tag'); ?>
</div>
</div>
<div class="control-group span6">
<div class="controls">
<?php echo JHtml::_('batch.language'); ?>
</div>
</div>
</div>
<div class="row-fluid">
<div class="control-group span6">
<div class="controls">
<?php echo JHtml::_('batch.access'); ?>
</div>
</div>
<?php if ($published >= 0) : ?>
<div class="control-group span6">
<div class="controls">
<?php echo JHtml::_('batch.item', 'com_content'); ?>
</div>
</div>
<?php endif; ?>
</div>
</div>
This makes use of the bootstrap classes row-fluid
and span6
instead of using inline styling.
Instead of adding custom max-height. One could probably also add a modal-batch class to the modal-body one and set a hight padding-bottom
and/or change overflow-y
to visible.
What do you think?
Labels |
Added:
?
|
I suggest to make sure you do not forget some batch actions (see Newsfeeds where language is missing in PR)
fixed now see: zero-24@df414e0
@Bakual
I start now some tests with it. Thanks for the example
Labels |
Added:
?
|
I have add now the idea from @Bakual
I hope this places for the less file is correct:
zero-24@ee6375c
Also we need a "hack" for com_contact if we would use this soution:
zero-24@f724969
There we can't use:
<div class="control-group span6">
for the contact batch.item option
we must use:
<div class="control-group">
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-02-03 12:06:30 |
@test
Able to reproduce then #2844 works as described for
-content
-banner
-categories
-contact
-menus
-modules
-newsfeeds
-users
-weblinks
-tags (new)
good improvement Tobias - thanks
Set First test since updated PR
You may blame the J!Tracker Application for transmitting this comment.