? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
25 Jan 2014

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33184&start=0

patch will display an error if attempting to save such a menu type:
"Please change the Menu type. The term 'menu' is reserved for back-end usage."

avatar infograf768 infograf768 - open - 25 Jan 2014
avatar brianteeman
brianteeman - comment - 25 Jan 2014

Shouldn't the error message say ...administrator or admin. Off the top of
my head (travelling right now) we don't use the term back-end

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33184&start=0

patch will display an error if attempting to save such a menu type:
"Please change the Menu type. The term 'menu' is reserved for back-end

usage."

You can merge this Pull Request by running

git pull https://github.com/infograf768/joomla-cms menutype

Or view, comment on, or merge it at:

#2843
Commit Summary

  • [#33184] Prevent using 'menu' as menutype as this is reserved for

File Changes

Patch Links:

Reply to this email directly or view it on
GitHub#2843
.

avatar infograf768
infograf768 - comment - 25 Jan 2014

@Bakual
I saw that existing string but I thought creating a specific string was more informative as TTs will have to update thier lang packs anyway.

@brianteeman
We already use the term back-end (3 times) or backend (63 times) in core. Sometimes it is added to Administrator in Tips as "Administrator Backend" or "Administrator (back-end)".

In both cases, lets' just decide to get this in 3.2.2 :)

avatar brianteeman
brianteeman - comment - 25 Jan 2014

In that case can we use the non hyphenated form please
On 25 Jan 2014 10:29, "infograf768" notifications@github.com wrote:

@Bakual https://github.com/Bakual
I saw that existing string but I thought creating a specific string was
more informative as TTs will have to update thier lang packs anyway.

@brianteeman https://github.com/brianteeman
We already use the term back-end (3 times) or backend (63 times) in core.
Sometimes it is added to Administrator in Tips as "Administrator Backend"
or "Administrator (back-end)".

In both cases, lets' just decide to get this in 3.2.2 :)


Reply to this email directly or view it on GitHub#2843 (comment)
.

avatar infograf768 infograf768 - change - 25 Jan 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 25 Jan 2014

Done.

avatar infograf768
infograf768 - comment - 25 Jan 2014

I added 'main' as it causes the same issue as 'menu'
See http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32869&start=0
menutype_main


I guess we should also port this to 2.5 without the new string

avatar Bakual
Bakual - comment - 25 Jan 2014

Code looks good and test was successfull.
Thanks JM.

avatar infograf768 infograf768 - change - 26 Jan 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-01-26 18:39:00
avatar infograf768 infograf768 - close - 26 Jan 2014
avatar infograf768 infograf768 - close - 26 Jan 2014
avatar infograf768 infograf768 - reference | 732c464 - 27 Jan 14
avatar Bakual Bakual - reference | 91f8dc7 - 12 May 14
avatar infograf768 infograf768 - head_ref_deleted - 12 Aug 2014

Add a Comment

Login with GitHub to post a comment