Ping @wilsonge .

@wilsonge Maybe it needs some additional cache cleaning in between the steps, deleting old plugin and deleting unused files and folders?

Do you have a stack trace? Where this error is coming from?

No idea. I have full error log to file on in my PHP settings, but there is no error logged in the log file.

But normally this error comes when trying to read XML files but the file is not there.

It should have been solved with #28399 , but seems that wasn't enough.

what happens when you enable the debug plugin? Any more info displayed than?

@zero-24 Thanks for kicking my ass to the debugger ;-)

Call stack
--
# | Function | Location
1 | () | JROOT/libraries/src/Installer/Adapter/PluginAdapter.php:424
2 | Joomla\CMS\Installer\Adapter\PluginAdapter->setupUninstall() | JROOT/libraries/src/Installer/InstallerAdapter.php:1180
3 | Joomla\CMS\Installer\InstallerAdapter->uninstall() | JROOT/libraries/src/Installer/Installer.php:764
4 | Joomla\CMS\Installer\Installer->uninstall() | JROOT/administrator/components/com_admin/script.php:412
5 | JoomlaInstallerScript->uninstallRepeatableFieldsPlugin() | JROOT/administrator/components/com_admin/script.php:96
6 | JoomlaInstallerScript->update() | JROOT/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php:866
7 | Joomla\Component\Joomlaupdate\Administrator\Model\UpdateModel->finaliseUpgrade() | JROOT/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php:180
8 | Joomla\Component\Joomlaupdate\Administrator\Controller\UpdateController->finalise() | JROOT/libraries/src/MVC/Controller/BaseController.php:728
9 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:146
10 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:384
11 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/AdministratorApplication.php:131
12 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT/libraries/src/Application/AdministratorApplication.php:174
13 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:231
14 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/administrator/includes/app.php:63
15 | require_once() | JROOT/administrator/index.php:36

It seems it fails when uninstalling the repeatable fields plugin.

hmm seams to be something broken in the uninstall of the plugin uninstallRepeatableFieldsPlugin.

Yep, am checking, but haven't found the mistake yet ;-)

The $this->group = (string) $this->getManifest()->attributes()->group; in the PluginAdapter fails. It seems it doesn't find any manifest file.

Or it doesn't have a group attribute.

Maybe order of processing in function uninstallRepeatableFieldsPlugin() in file script.phpis wrong? To me it seems to be ok. Or maybe we should do the $db->transactionCommit(); there before we run the installer to uninstall the plugin, and not after like it is now?

@Hackwar Any idea?

https://github.com/joomla/joomla-cms/blob/staging/plugins/fields/repeatable/repeatable.xml#L2

hmm the xml looks good to me maybe the path used is not the correct one?

Is that function running before or after the plugin was removed from the filesystem? It doesn’t matter if the manifest looks right or not, if it’s not there then you’re SOL.

@mbabker It was changed with PR #28399 to run before the removal from file system. And after the update, the script.php which is there includes that change.

It's related to this https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/restore_finalisation.php#L75

I forgot at the end of restore.php we trash all the files :( That's before we call the usual script methods. Which is unfortunate. Not really sure how best to work around that.

@wilsonge At least we have an explanation now. Easy fix: Add it to the readme of the known issues like we have it (hopefully) for the "template style does not exist" message ;-) (joking)

@wilsonge Could we exclude the files and folders of that plugin from the delete files routine and the delete folders (and also from the script to generate those lists)? Shouldn't the uninstallation of the plugin remove that stuff already?

Alternatively, we could change the function uninstallRepeatableFieldsPlugin in script.php so it doesn't uninstall the plugin anymore using the extensions installer but is deleting database stuff like e.g. the record in the extensions table itself.

@wilsonge Could we exclude the files and folders of that plugin from the delete files routine and the delete folders (and also from the script to generate those lists)? Shouldn't the uninstallation of the plugin remove that stuff already?

Yes I think that's the correct thing to do

Have just tested with a patched update zip and it works.

Patch was change in script.php as shown here: 4.0-dev...richard67:4.0-dev-test-issue-28432

Custom URL for testing: https://test5.richard-fath.de/next_major_list_issue-28432.xml.

looks good to me. ?

@zero-24 Problem is it doesn't make sense that I make a PR with that fix. @wilsonge has to change the procedure to generate these lists in script.php instead.

Make the PR its fine

You mean I shall make? Ok, will do so.

a342106 script updated. just do the PR :) saves me from downloading nightlies and doing diff's :)

Closing as having PR. Please test #28433 .

a342106 script updated. just do the PR :) saves me from downloading nightlies and doing diff's :)

@wilsonge LGTM.