NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 Mar 2020

Summary of Changes

This replaces htmlhelper to webaset for layouts

Updated layouts:

joomla/html/batch/item
joomla/html/batch/language
joomla/html/batch/adminlanguage
joomla/form/field/calendar
joomla/form/field/color/slider
joomla/form/field/password
joomla/form/renderfield
joomla/toolbar/containeropen
joomla/searchtools/default/filters
joomla/edit/frontediting_modules
joomla/content/options_default
plugins/system/webauthn/manage

Testing Instructions

Apply patch. Run npm install
Click around, check calendar, template style colors, batch, fields "showon",
all should work as before

Expected result

All work

Actual result

All work

Documentation Changes Required

nope

ref #22435

9a6b540 22 Mar 2020 avatar Fedik run 1
1478e23 22 Mar 2020 avatar Fedik run 2
0dae88f 22 Mar 2020 avatar Fedik run 3
0c48c0f 22 Mar 2020 avatar Fedik run 4
avatar Fedik Fedik - open - 22 Mar 2020
avatar Fedik Fedik - change - 22 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2020
Category Repository NPM Change Layout
avatar Fedik Fedik - change - 22 Mar 2020
The description was changed
avatar Fedik Fedik - edited - 22 Mar 2020
avatar Fedik Fedik - change - 22 Mar 2020
The description was changed
avatar Fedik Fedik - edited - 22 Mar 2020
avatar Fedik Fedik - change - 22 Mar 2020
The description was changed
avatar Fedik Fedik - edited - 22 Mar 2020
avatar Fedik Fedik - change - 28 Mar 2020
Labels Added: NPM Resource Changed ?
avatar alikon
alikon - comment - 4 Apr 2020

I have tested this item successfully on ff7a94f

tested with the new patchtester 4
so i'vent runned npm install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28431.

avatar alikon alikon - test_item - 4 Apr 2020 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2020
Category Repository NPM Change Layout Administration com_config Repository NPM Change Front End com_contact Layout
avatar Fedik
Fedik - comment - 5 Apr 2020

I have added all "showon" cases to this PR, to make "showon" use WebAsset in all places,
this now fully cover #28456

avatar wilsonge wilsonge - change - 5 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-05 12:09:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Apr 2020
avatar wilsonge wilsonge - merge - 5 Apr 2020
avatar wilsonge
wilsonge - comment - 5 Apr 2020

LGTM! Thanks!

avatar bugsmafia
bugsmafia - comment - 13 Apr 2020

This began to cause a drop wherever the password field is involved.

An error has occurred.
0 There is no "field.passwordview" asset of a "script" type in the registry.
iYUFsjZDTUmveTa7WhpYUQ 1

Add a Comment

Login with GitHub to post a comment