Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28405] - [4.0] Fix content history modal

? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
20 Mar 2020

Pull Request for Issue #24491

Summary of Changes

This PR takes off the btn-group class as it does not bring anything useful and breaks the RTL border-radius settings. Buttons will now be separated and much more readable anyway.
It also adds margins when displaying the Versions Modal in frontend.

Before patch

Screen Shot 2020-03-20 at 10 50 15

Screen Shot 2020-03-20 at 10 49 14

Screen Shot 2020-03-20 at 10 48 29

Screen Shot 2020-03-20 at 10 47 05

After patch

Screen Shot 2020-03-20 at 10 42 20after

Screen Shot 2020-03-20 at 10 42 09after

Screen Shot 2020-03-20 at 10 41 17after

Screen Shot 2020-03-20 at 11 05 24

Note

Remains to solve a Atum behavior
a float-right in LTR should give a float-left in RTL as it righfully does in Cassiopea

The scss in Cassiopea is correct

.float-right {
    float: left !important;
}

But not in Atum.
It looks like

.float-right {
  float: left !important;
}

.float-left {
  float: right !important;
}

was not added in ATUM template-rtl.scss because of the use of flex-start and flex-end.
As the code for the contenthistory modal does not use searchtools but directly uses float-right and not flex we may have to add these in rtl.

Should be discussed and solved in another PR I guess.

avatar infograf768 infograf768 - open - 20 Mar 2020
avatar infograf768 infograf768 - change - 20 Mar 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2020
Category ⇒ Administration com_content com_contenthistory Front End Templates (site)
avatar BertaOctech
BertaOctech - comment - 2 Apr 2020

Hi.

How do you install languages on J4 beta for testing.
I tried to install additional languages but received an error "Unable to find install package"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28405.
avatar brianteeman
brianteeman - comment - 2 Apr 2020

the only languages available are frencg, german and persian at this time

avatar BertaOctech
BertaOctech - comment - 2 Apr 2020

I have tested this item ✅ successfully on 0c1a07d

I tested the patch and it worked as expected.

I compared the article versions modal both in english and persian (thank you Brian). In fact buttons styles were improved.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28405.

avatar BertaOctech BertaOctech - test_item - 2 Apr 2020 - Tested successfully
avatar pabloarias
pabloarias - comment - 2 Apr 2020

I have tested this item ✅ successfully on 0c1a07d

I've tested it in Firefox and Chromium, in English and Persian.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28405.

avatar pabloarias pabloarias - test_item - 2 Apr 2020 - Tested successfully
avatar Quy Quy - change - 2 Apr 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 2 Apr 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28405.

avatar rdeutz rdeutz - close - 4 Apr 2020
avatar rdeutz rdeutz - merge - 4 Apr 2020
avatar rdeutz rdeutz - change - 4 Apr 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-04-04 12:53:24
Closed_By ⇒ rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment