Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Mar 2020

PR for #28363

npm i or node build.js --compile-css

image

The second button should have rounded corners top-right and bottom-right. But the css only applies that rule to the last-child.

In this case its not the last-child because there are two additional children that are hidden
image

avatar brianteeman brianteeman - open - 20 Mar 2020
avatar brianteeman brianteeman - change - 20 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2020
Category Administration Templates (admin)
avatar SharkyKZ
SharkyKZ - comment - 20 Mar 2020

Small issue when there are 3 buttons:

Screenshot_2020-03-20 Menus Edit Item - Joomla - Administration

avatar brianteeman
brianteeman - comment - 20 Mar 2020

where do you see that and I will check

avatar SharkyKZ
SharkyKZ - comment - 20 Mar 2020

Nowhere in core. But this will occur wherever 3 visible buttons are used.

avatar SharkyKZ
SharkyKZ - comment - 20 Mar 2020

Correction: we do have a case of this in core. Set up a multilingual site with at least 3 languages. Edit a menu item assigned to a language and go to Associations tab.

avatar jwaisner jwaisner - change - 20 Mar 2020
Priority Medium Very low
avatar brianteeman
brianteeman - comment - 20 Mar 2020

@SharkyKZ I confirm your finding but its beyond my skill to resolve

avatar wilsonge
wilsonge - comment - 10 Apr 2020

@ciar4n as you're doing some Joomla PRs at the moment could i ask you to take a look at this one?

avatar brianteeman
brianteeman - comment - 10 Apr 2020

yes please

avatar ciar4n
ciar4n - comment - 11 Apr 2020

Not ideal but works... #28645

avatar brianteeman
brianteeman - comment - 11 Apr 2020

Closed see #28645

avatar brianteeman brianteeman - close - 11 Apr 2020
avatar brianteeman brianteeman - change - 11 Apr 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-04-11 11:14:19
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment