[#28399] - [4.0] Fix order of uninstallation of repeatable fields plugin
- Fixed in Code Base
- 20 Mar 2020
- Medium
- Build: 4.0-dev
- # 28399
- Diff
- wilsonge:fix-rep-uninstall
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #28385
Summary of Changes
Fixes the update of Joomla 3.10 to Joomla 4.0
Testing Instructions
Upgrade from 3.10 to 4.0. Before you get the error 0 Call to a member function attributes() on null because the manifest file for the repeatable fields plugin has been removed in the deleteUnexistingFiles function before the uninstallRepeatableFieldsPlugin. So I've just moved the uninstallation up the pecking order.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
Tested updating a current 3.10-dev branch to latest 4.0-dev nightly with following custom URLs:
- For reproducing the issue https://update.joomla.org/core/nightlies/next_major_list.xml
- For testing if this PR solves it https://test5.richard-fath.de/next_major_list_pr-28399.xml
The latter is the nightly of tonight plus the patch of this PR applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.
Additional hint for other testers:
Without this PR applied, you get in addition to the error described in the description of this PR an error in your PHP error log (if that is switched on in your PHP settings):
PHP Warning: simplexml_load_file(): I/O warning : failed to load external entity "/home/richard/lamp/public_html/joomla-cms-3.10-dev/plugins/fields/repeatable/repeatable.xml"; in /home/richard/lamp/public_html/joomla-cms-3.10-dev/libraries/src/Installer/Installer.php on line 2034.
With this PR applied, this error disappears (but others might remains, which are not subject of this PR).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-20 10:48:27 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks guys!
Thanks too, guy
Can’t do real test now, but review looks good. Correction fits to what was reported in PHP error log.