[#28384] - [4.0][api][com_content] remove notice when Multilingual
- Fixed in Code Base
- 19 Mar 2020
- Medium
- Build: 4.0-dev
- # 28384
- Diff
- alikon:patch-116
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
redo of #27071 .
Summary of Changes
- added fulltext field to the articles model select list
- fixed multilanguage
Testing Instructions
- install a multingual site
- run Multilingual Sample Data
- call the api api/index.php/v1/content/article
Expected result
no notice
Actual result
PHP Notice: Undefined property: stdClass::$fulltext in ../api/components/com_content/src/View/Articles/JsonapiView.php on line 149
PHP Notice: Undefined property: stdClass::$associations in /var/www/html/jbs4/api/components/com_content/src/View/Articles/JsonapiView.php on line 164
cc @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384.
Just holding on merging this as need to reproduce. I think we may want to make multilang associations an empty array in this case rather than not render at all. BUT need to test to be sure :)
And do we want fulltext always loaded in backend?
We already started pulling out several properties to the api. fulltext isn't the end of the world. I don't like the associations fix but it's more related to how prepareItem works - think it needs to be aware of whether it's a list or item - but that's for a future PR. this will do for now
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-19 23:19:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 5eca290
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384.