Feeling Lucky
?
[#28383] - [4.0] Unused file in use section
- Fixed in Code Base
- 18 Mar 2020
- Medium
- Build: 4.0-dev
- # 28383
- Diff
- astridx:unusedactionlogscontroller
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
I deleted a unused file in use section
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
| Category | Administration | ⇒ | Administration Front End com_contact |
astridx
- comment
- 18 Mar 2020
OK
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-18 10:59:38 |
| Closed_By | ⇒ | astridx |
astridx
- comment
- 18 Mar 2020
Accidentally closed.
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-03-18 10:59:38 | ⇒ | |
| Closed_By | astridx | ⇒ |
| Status | New | ⇒ | Pending |
| Category | Administration Front End com_contact | ⇒ | Front End com_contact |
astridx
- comment
- 18 Mar 2020
I changed the PR.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-18 11:26:40 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 18 Mar 2020
LGTM!
It's being used kinda - the doc block for the constructor needs to be modified to fix the typecasing https://github.com/joomla/joomla-cms/pull/28383/files#diff-95c09e0e76d96872426ab1238596e4a9L43 rather than the import removed