[#28380] - [4.0] Update Button API typehints
- Fixed in Code Base
- 9 Apr 2020
- Low
- Build: 4.0-dev
- # 28380
- Diff
- SharkyKZ:j4/button/default-state
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #24305, this updates state value type to integer.
Testing Instructions
Go to article list in backend. Inspect featured/transition icons.
Go to database, manually edit featured value of some article in #__content table. Change it to 2 or more. View the article in the article list.
Expected result
Works like before.
Article with modified featured value shows Unknown State icon.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Libraries |
jwaisner
- | Priority | Medium | ⇒ | Low |
| Labels |
Added:
?
|
||
I have not tested this item.
I done the test instruction befor apply the patch.
I have the expected resut without the patch...
EDIT: I see now on github that @wilsonge approved these changes 22 days ago... why it is in the Joomla! Issue Tracker ? XD
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28380.
Because I can't merge everything based on code review. Often I want to see a test too to be confident in what I'm merging :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-09 15:17:14 |
| Closed_By | ⇒ | wilsonge |
Thanks!
@SharkyKZ I hope I can find time soon for testing. But I think you should extend your testing instructions a bit:
And maybe the test with changing the value to a number larger than 1 in the database should be done for published, too.